Skip to content

feat(curations): Add a VCS curation for NPM::three #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(curations): Add a VCS curation for NPM::three #343

wants to merge 1 commit into from

Conversation

@cz-dev-ge
Copy link
Contributor

@cz-dev-ge cz-dev-ge commented Sep 23, 2025

three.js releases are tagged like this: r<feature release>, e.g. instead of 0.178.0 the tag says r178 and is not found by ort.

@cz-dev-ge cz-dev-ge requested a review from a team as a code owner September 23, 2025 09:52
@cz-dev-ge
Copy link
Contributor Author

cz-dev-ge commented Sep 23, 2025 •
edited
Loading

This is the log:

12:28:00.339 [DefaultDispatcher-worker-15] INFO  org.ossreviewtoolkit.downloader
.VersionControlSystem - No Git revision for package 'three' and version '0.178.0'
found: IOException: No matching tag for version '0.178.0' found in [
r101, r100, r50, r51, r105, r52, r104, r53, r103, r54, r102, r55, r109, r56, 
r108, r57, r107, r58, r106, r59, r180, r174, r173, r172, r171, r178, r177, 
r60, r176, r61, r175, r62, r63, r64, r65, r179, r66, r67, r68, r69, r170, 
r163, r162, r161, r160, r167, r70, r166, r71, r165, r72, r164, r73, r74, 
r75, r169, r76, r168, r77, r78, r79, r152, r151, r150, r80, r156, r81, r155, 
r82, r154, r83, r153, r84, r85, r159, r86, r158, r87, r157, r88, r89, r16, 
r2, r1, r17, r18, r9, r8, r7, r6, r5, r4, r3, r141, r140, r90, r91, r145, 
r92, r144, r93, r143, r94, r142, r95, r149, r96, r148, r97, r10, r147, r98, 
r11, r146, r99, r12, r13, r14, r15, r28, r29, r130, r134, r133, r132, r131, 
r138, r137, r136, r135, r25, r139, r38, r39, r123, r122, r121, r120, r127, 
r30, r126, r31, r125, r32, r124, r33, r41/ROME, r34, r35, r129, r36, r128, 
r37, r49, r112, r111, r110, r40, r116, r115, r42, r114, r43, r113, r44, r45, 
r119, r46, r118, r47, r117, r48]. 
Please create a tag whose name contains the version.

@sschuberth
Copy link
Member

sschuberth commented Sep 23, 2025

Ok, this indeed does not even have a gitHead at https://registry.npmjs.org/three.

sschuberth
sschuberth requested changes Sep 23, 2025
View reviewed changes
curations/NPM/_/three.yml
vcs:
type: "Git"
url: "https://github.com/mrdoob/three.js.git"
revision: "3b1ff7661884f26e6d9af1d94c293129aaba885c"
Copy link
Member

@sschuberth sschuberth Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've verified this to match https://github.com/mrdoob/three.js/releases/tag/r178.

curations/NPM/_/three.yml Outdated
Comment on lines 5 to 6
type: "Git"
url: "https://github.com/mrdoob/three.js.git"
Copy link
Member

@sschuberth sschuberth Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these two lines can be omitted, right?

Copy link
Contributor Author

@cz-dev-ge cz-dev-ge Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes.

Copy link
Member

@sschuberth sschuberth Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the change to move things forward. @fviernau please also re-review.

fviernau
fviernau requested changes Oct 22, 2025
View reviewed changes
curations/NPM/_/three.yml Outdated
curations:
comment: "Commit of release 0.178.0 is tagged r178."
vcs:
type: "Git"
Copy link
Member

@fviernau fviernau Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit sets the type and url, which is not necessary.
I would propose to simply set the revision to r178,, to simpliy.

Copy link
Member

@sschuberth sschuberth Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit sets the type and url, which is not necessary.

Yes, also see my comment above.

@cz-dev-ge @sschuberth
feat(curations): Add a VCS curation for NPM::three:0.178.0
6c43e33 
three.js releases are tagged like `r<feature release>`, e.g. instead of
0.178.0 the tag says r178 and is not found by ORT.

Signed-off-by: cz-dev-ge <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth enabled auto-merge (rebase) October 22, 2025 12:38
@sschuberth sschuberth requested a review from fviernau October 22, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sschuberth sschuberth sschuberth approved these changes

@fviernau fviernau Awaiting requested review from fviernau

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cz-dev-ge @sschuberth @fviernau